X-Git-Url: https://git.armaanb.net/?a=blobdiff_plain;f=slock.c;h=47231021ced0cb9416d45979ce145786cee0b54f;hb=a430a647e48a894499143b03da86e5707b4127df;hp=866df90d8a99815d9487150af6dc1adfc3ca6401;hpb=20e294a66f4925b7db43e77ddcb0b885fedeca18;p=slock.git

diff --git a/slock.c b/slock.c
index 866df90..4723102 100644
--- a/slock.c
+++ b/slock.c
@@ -7,6 +7,7 @@
 
 #include <ctype.h>
 #include <pwd.h>
+#include <stdarg.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
@@ -16,15 +17,23 @@
 #include <X11/Xlib.h>
 #include <X11/Xutil.h>
 
+void
+eprint(const char *errstr, ...) {
+	va_list ap;
+
+	va_start(ap, errstr);
+	vfprintf(stderr, errstr, ap);
+	va_end(ap);
+	exit(EXIT_FAILURE);
+}
+
 const char *
 get_password() { /* only run as root */
 	const char *rval;
 	struct passwd *pw;
 
-	if(geteuid() != 0) {
-		fputs("slock: cannot retrieve password entry (make sure to suid slock)\n", stderr);
-		exit(EXIT_FAILURE);
-	}
+	if(geteuid() != 0)
+		eprint("slock: cannot retrieve password entry (make sure to suid slock)\n");
 	pw = getpwuid(getuid());
 	endpwent();
 	rval =  pw->pw_passwd;
@@ -38,10 +47,8 @@ get_password() { /* only run as root */
 	}
 #endif
 	/* drop privileges */
-	if(setgid(pw->pw_gid) < 0 || setuid(pw->pw_uid) < 0) {
-		fputs("slock: cannot drop privileges\n",stdout);
-		exit(EXIT_FAILURE);
-	}
+	if(setgid(pw->pw_gid) < 0 || setuid(pw->pw_uid) < 0)
+		eprint("slock: cannot drop privileges\n");
 	return rval;
 }
 
@@ -62,15 +69,13 @@ main(int argc, char **argv) {
 	XEvent ev;
 	XSetWindowAttributes wa;
 
-	if((argc > 1) && !strncmp(argv[1], "-v", 3)) {
-		fputs("slock-"VERSION", © 2006-2007 Anselm R. Garbe\n", stdout);
-		exit(EXIT_SUCCESS);
-	}
+	if((argc == 2) && !strcmp("-v", argv[1]))
+		eprint("slock-"VERSION", © 2006-2007 Anselm R. Garbe\n");
+	else if(argc != 1)
+		eprint("usage: slock [-v]\n");
 	pws = get_password();
-	if(!(dpy = XOpenDisplay(0))) {
-		fputs("slock: cannot open display\n", stderr);
-		exit(EXIT_FAILURE);
-	}
+	if(!(dpy = XOpenDisplay(0)))
+		eprint("slock: cannot open display\n");
 	screen = DefaultScreen(dpy);
 	root = RootWindow(dpy, screen);
 
@@ -87,7 +92,7 @@ main(int argc, char **argv) {
 	XMapRaised(dpy, w);
 	for(len = 1000; len; len--) {
 		if(XGrabPointer(dpy, root, False, ButtonPressMask | ButtonReleaseMask | PointerMotionMask,
-			GrabModeAsync, GrabModeSync, None, invisible, CurrentTime) == GrabSuccess)
+			GrabModeAsync, GrabModeAsync, None, invisible, CurrentTime) == GrabSuccess)
 			break;
 		usleep(1000);
 	}