From: Duncaen <mail@duncano.de>
Date: Wed, 30 Jan 2019 22:17:49 +0000 (+0100)
Subject: shadow: clear the password even after a mismatch
X-Git-Tag: v6.6~30
X-Git-Url: https://git.armaanb.net/?p=opendoas.git;a=commitdiff_plain;h=a283d2f0e2569329bd13f97d2d61f7556ea51b30

shadow: clear the password even after a mismatch
---

diff --git a/shadow.c b/shadow.c
index a775b2b..53877d5 100644
--- a/shadow.c
+++ b/shadow.c
@@ -64,9 +64,14 @@ shadowauth(const char *myname, int persist)
 			"tty required for %s", myname);
 		errx(1, "a tty is required");
 	}
-	if ((encrypted = crypt(response, hash)) == NULL)
-		err(1, "crypt");
+	if (response == NULL)
+		err(1, "readpassphrase");
+	if ((encrypted = crypt(response, hash)) == NULL) {
+		explicit_bzero(rbuf, sizeof(rbuf));
+		errx(1, "Authorization failed");
+	}
 	if (strcmp(encrypted, hash) != 0) {
+		explicit_bzero(rbuf, sizeof(rbuf));
 		syslog(LOG_AUTHPRIV | LOG_NOTICE, "failed auth for %s", myname);
 		errx(1, "Authorization failed");
 	}