From 8457259ddd14ed896b8cf2b69d85c4f567bde5ce Mon Sep 17 00:00:00 2001 From: Ted Unangst Date: Sun, 26 Jul 2015 19:14:46 +0000 Subject: [PATCH] tweak config checking slightly --- doas.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/doas.c b/doas.c index 618027b..be48957 100644 --- a/doas.c +++ b/doas.c @@ -1,4 +1,4 @@ -/* $OpenBSD: doas.c,v 1.22 2015/07/26 17:24:02 zhuk Exp $ */ +/* $OpenBSD: doas.c,v 1.23 2015/07/26 19:08:17 zhuk Exp $ */ /* * Copyright (c) 2015 Ted Unangst * @@ -284,7 +284,8 @@ fail(void) static int checkconfig(const char *confpath, int argc, char **argv, - uid_t uid, gid_t *groups, int ngroups, uid_t target) { + uid_t uid, gid_t *groups, int ngroups, uid_t target) +{ struct rule *rule; setresuid(uid, uid, uid); @@ -295,10 +296,10 @@ checkconfig(const char *confpath, int argc, char **argv, if (permit(uid, groups, ngroups, &rule, target, argv[0], (const char **)argv + 1)) { printf("permit%s\n", (rule->options & NOPASS) ? " nopass" : ""); - return 1; + exit(0); } else { printf("deny\n"); - return 0; + exit(1); } } @@ -369,9 +370,12 @@ main(int argc, char **argv, char **envp) argc = 1; } - if (confpath) - exit(!checkconfig(confpath, argc, argv, uid, groups, ngroups, - target)); + if (confpath) { + checkconfig(confpath, argc, argv, uid, groups, ngroups, + target); + exit(1); /* fail safe */ + } + parseconfig("/etc/doas.conf", 1); /* cmdline is used only for logging, no need to abort on truncate */ -- 2.39.2