X-Git-Url: https://git.armaanb.net/?p=sic.git;a=blobdiff_plain;f=util.c;h=8cea8836cf6dc14dbadb5394201b45cda9dc0d34;hp=25678120422eea5ec0782e9040fdd5ad24b9ff45;hb=HEAD;hpb=df4c0611366bf361fa263fbc57009cbe68456855

diff --git a/util.c b/util.c
index 2567812..8cea883 100644
--- a/util.c
+++ b/util.c
@@ -18,9 +18,9 @@ eprint(const char *fmt, ...) {
 
 static int
 dial(char *host, char *port) {
-	static struct addrinfo hints;
-	int srv;
+	struct addrinfo hints;
 	struct addrinfo *res, *r;
+	int fd;
 
 	memset(&hints, 0, sizeof hints);
 	hints.ai_family = AF_UNSPEC;
@@ -28,21 +28,21 @@ dial(char *host, char *port) {
 	if(getaddrinfo(host, port, &hints, &res) != 0)
 		eprint("error: cannot resolve hostname '%s':", host);
 	for(r = res; r; r = r->ai_next) {
-		if((srv = socket(r->ai_family, r->ai_socktype, r->ai_protocol)) == -1)
+		if((fd = socket(r->ai_family, r->ai_socktype, r->ai_protocol)) == -1)
 			continue;
-		if(connect(srv, r->ai_addr, r->ai_addrlen) == 0)
+		if(connect(fd, r->ai_addr, r->ai_addrlen) == 0)
 			break;
-		close(srv);
+		close(fd);
 	}
 	freeaddrinfo(res);
 	if(!r)
 		eprint("error: cannot connect to host '%s'\n", host);
-	return srv;
+	return fd;
 }
 
 static char *
 eat(char *s, int (*p)(int), int r) {
-	while(*s != '\0' && p(*s) == r)
+	while(*s != '\0' && p((unsigned char)*s) == r)
 		s++;
 	return s;
 }
@@ -60,8 +60,7 @@ static void
 trim(char *s) {
 	char *e;
 
-	e = s + strlen(s) - 1;
-	while(e > s && isspace(*e))
-		e--;
-	*(e + 1) = '\0';
+	for (e = s + strlen(s); e > s && isspace((unsigned char)*(e - 1)); e--)
+		;
+	*e = '\0';
 }