]> git.armaanb.net Git - st.git/commit
Fixed 'missing glyph doesn't use fontconfig config substitutions' bug
authorSpencer Phippen <spencer.phippen@gmail.com>
Wed, 23 Nov 2016 18:17:59 +0000 (19:17 +0100)
committerRoberto E. Vargas Caballero <k0ga@shike2.com>
Thu, 24 Nov 2016 19:20:45 +0000 (20:20 +0100)
commitfa9a4599720703932d1c4f16b9aeee1f91f96263
tree12e9d6a0680f8603ca630dbfdaaac9807d26677d
parent740ada1447a0bf9eb7db327d9433fa0b96e0a4d8
Fixed 'missing glyph doesn't use fontconfig config substitutions' bug

XftFontMatch does display-specific font configuration (commit 528241a).
Nice. Unfortunately, when we switched from FcFontMatch, we also stopped
storing the post-Fc{Config,Default}Substitute FcPattern for future
lookups. The result is that if a glyph isn't found in the primary font,
secondary font lookups use the original FcPattern, not the configured
one. If you have custom fontconfig rules (like me), this can be
disappointing.

I basically just copied the guts out of XftFontMatch[1] and saved
the intermediate configured FcPattern. Could be related to the bug that
inspired commit 4242027.

[1]: https://cgit.freedesktop.org/xorg/lib/libXft/tree/src/xftfont.c
st.c