]> git.armaanb.net Git - stagit.git/blobdiff - stagit.c
consistency for messages for special-case in diffstat
[stagit.git] / stagit.c
index 80544e2c7737e24364dc821d091b3d33efaabc6c..4048873192d343788c944407fc56c70e5e5f83d2 100644 (file)
--- a/stagit.c
+++ b/stagit.c
@@ -57,7 +57,7 @@ static const char *relpath = "";
 static const char *repodir;
 
 static char *name = "";
-static char *stripped_name;
+static char *strippedname;
 static char description[255];
 static char cloneurl[1024];
 static int haslicense, hasreadme, hassubmodules;
@@ -76,6 +76,18 @@ pledge(const char *promises, const char *paths[])
 }
 #endif
 
+void
+joinpath(char *buf, size_t bufsiz, const char *path, const char *path2)
+{
+       int r;
+
+       r = snprintf(buf, bufsiz, "%s%s%s",
+               path, path[0] && path[strlen(path) - 1] != '/' ? "/" : "", path2);
+       if (r == -1 || (size_t)r >= bufsiz)
+               errx(1, "path truncated: '%s%s%s'",
+                       path, path[0] && path[strlen(path) - 1] != '/' ? "/" : "", path2);
+}
+
 void
 deltainfo_free(struct deltainfo *di)
 {
@@ -113,7 +125,7 @@ commitinfo_getstats(struct commitinfo *ci)
 
                delta = git_patch_get_delta(patch);
 
-               /* check binary data */
+               /* skip stats for binary data */
                if (delta->flags & GIT_DIFF_FLAG_BINARY)
                        continue;
 
@@ -246,27 +258,6 @@ xmlencode(FILE *fp, const char *s, size_t len)
        }
 }
 
-/* Some implementations of dirname(3) return a pointer to a static
- * internal buffer (OpenBSD). Others modify the contents of `path` (POSIX).
- * This is a wrapper function that is compatible with both versions.
- * The program will error out if dirname(3) failed, this can only happen
- * with the OpenBSD version. */
-char *
-xdirname(const char *path)
-{
-       char *p, *b;
-
-       if (!(p = strdup(path)))
-               err(1, "strdup");
-       if (!(b = dirname(p)))
-               err(1, "dirname");
-       if (!(b = strdup(b)))
-               err(1, "strdup");
-       free(p);
-
-       return b;
-}
-
 int
 mkdirp(const char *path)
 {
@@ -306,19 +297,18 @@ printtime(FILE *fp, const git_time *intime)
 {
        struct tm *intm;
        time_t t;
-       int offset, sign = '+';
        char out[32];
 
-       offset = intime->offset * 60;
-       t = (time_t)intime->time + offset;
+       t = (time_t)intime->time + (intime->offset * 60);
        if (!(intm = gmtime(&t)))
                return;
        strftime(out, sizeof(out), "%a %b %e %H:%M:%S", intm);
-       if (offset < 0) {
-               offset = -offset;
-               sign = '-';
-       }
-       fprintf(fp, "%s %c%02d%02d", out, sign, offset / 60, offset % 60);
+       if (intime->offset < 0)
+               fprintf(fp, "%s -%02d%02d", out,
+                           -(intime->offset) / 60, -(intime->offset) % 60);
+       else
+               fprintf(fp, "%s +%02d%02d", out,
+                           intime->offset / 60, intime->offset % 60);
 }
 
 void
@@ -335,7 +325,7 @@ printtimeshort(FILE *fp, const git_time *intime)
        fputs(out, fp);
 }
 
-int
+void
 writeheader(FILE *fp, const char *title)
 {
        fputs("<!DOCTYPE html>\n"
@@ -343,9 +333,9 @@ writeheader(FILE *fp, const char *title)
                "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\" />\n"
                "<meta http-equiv=\"Content-Language\" content=\"en\" />\n<title>", fp);
        xmlencode(fp, title, strlen(title));
-       if (title[0] && stripped_name[0])
+       if (title[0] && strippedname[0])
                fputs(" - ", fp);
-       xmlencode(fp, stripped_name, strlen(stripped_name));
+       xmlencode(fp, strippedname, strlen(strippedname));
        if (description[0])
                fputs(" - ", fp);
        xmlencode(fp, description, strlen(description));
@@ -357,7 +347,7 @@ writeheader(FILE *fp, const char *title)
        fprintf(fp, "<a href=\"../%s\"><img src=\"%slogo.png\" alt=\"\" width=\"32\" height=\"32\" /></a>",
                relpath, relpath);
        fputs("</td><td><h1>", fp);
-       xmlencode(fp, stripped_name, strlen(stripped_name));
+       xmlencode(fp, strippedname, strlen(strippedname));
        fputs("</h1><span class=\"desc\">", fp);
        xmlencode(fp, description, strlen(description));
        fputs("</span></td></tr>", fp);
@@ -379,14 +369,12 @@ writeheader(FILE *fp, const char *title)
        if (haslicense)
                fprintf(fp, " | <a href=\"%sfile/LICENSE.html\">LICENSE</a>", relpath);
        fputs("</td></tr></table>\n<hr/>\n<div id=\"content\">\n", fp);
-
-       return 0;
 }
 
-int
+void
 writefooter(FILE *fp)
 {
-       return !fputs("</div>\n</body>\n</html>\n", fp);
+       fputs("</div>\n</body>\n</html>\n", fp);
 }
 
 int
@@ -465,7 +453,7 @@ printshowfile(FILE *fp, struct commitinfo *ci)
            ci->ndeltas   > 1000   ||
            ci->addcount  > 100000 ||
            ci->delcount  > 100000) {
-               fprintf(fp, "(diff is too large, output suppressed)");
+               fputs("Diff is too large, output suppressed.\n", fp);
                return;
        }
 
@@ -473,7 +461,7 @@ printshowfile(FILE *fp, struct commitinfo *ci)
        fputs("<b>Diffstat:</b>\n<table>", fp);
        for (i = 0; i < ci->ndeltas; i++) {
                delta = git_patch_get_delta(ci->deltas[i]->patch);
-               fputs("<tr><td>", fp);
+               fprintf(fp, "<tr><td><a href=\"#h%zu\">", i);
                xmlencode(fp, delta->old_file.path, strlen(delta->old_file.path));
                if (strcmp(delta->old_file.path, delta->new_file.path)) {
                        fputs(" -&gt; ", fp);
@@ -493,7 +481,7 @@ printshowfile(FILE *fp, struct commitinfo *ci)
                memset(&linestr, '+', add);
                memset(&linestr[add], '-', del);
 
-               fprintf(fp, "</td><td> | </td><td class=\"num\">%zu</td><td><span class=\"i\">",
+               fprintf(fp, "</a></td><td> | </td><td class=\"num\">%zu</td><td><span class=\"i\">",
                        ci->deltas[i]->addcount + ci->deltas[i]->delcount);
                fwrite(&linestr, 1, add, fp);
                fputs("</span><span class=\"d\">", fp);
@@ -510,13 +498,13 @@ printshowfile(FILE *fp, struct commitinfo *ci)
        for (i = 0; i < ci->ndeltas; i++) {
                patch = ci->deltas[i]->patch;
                delta = git_patch_get_delta(patch);
-               fprintf(fp, "<b>diff --git a/<a href=\"%sfile/%s.html\">%s</a> b/<a href=\"%sfile/%s.html\">%s</a></b>\n",
-                       relpath, delta->old_file.path, delta->old_file.path,
+               fprintf(fp, "<b>diff --git a/<a id=\"h%zu\" href=\"%sfile/%s.html\">%s</a> b/<a href=\"%sfile/%s.html\">%s</a></b>\n",
+                       i, relpath, delta->old_file.path, delta->old_file.path,
                        relpath, delta->new_file.path, delta->new_file.path);
 
                /* check binary data */
                if (delta->flags & GIT_DIFF_FLAG_BINARY) {
-                       fputs("Binary files differ\n", fp);
+                       fputs("Binary files differ.\n", fp);
                        continue;
                }
 
@@ -693,7 +681,7 @@ writeatom(FILE *fp)
 
        fputs("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"
              "<feed xmlns=\"http://www.w3.org/2005/Atom\">\n<title>", fp);
-       xmlencode(fp, stripped_name, strlen(stripped_name));
+       xmlencode(fp, strippedname, strlen(strippedname));
        fputs(", branch HEAD</title>\n<subtitle>", fp);
        xmlencode(fp, description, strlen(description));
        fputs("</subtitle>\n", fp);
@@ -724,18 +712,16 @@ writeblob(git_object *obj, const char *fpath, const char *filename, git_off_t fi
        int lc = 0;
        FILE *fp;
 
-       d = xdirname(fpath);
-       if (mkdirp(d)) {
-               free(d);
+       if (strlcpy(tmp, fpath, sizeof(tmp)) >= sizeof(tmp))
+               errx(1, "path truncated: '%s'", fpath);
+       if (!(d = dirname(tmp)))
+               err(1, "dirname");
+       if (mkdirp(d))
                return -1;
-       }
-       free(d);
 
-       p = fpath;
-       while (*p) {
+       for (p = fpath, tmp[0] = '\0'; *p; p++) {
                if (*p == '/' && strlcat(tmp, "../", sizeof(tmp)) >= sizeof(tmp))
                        errx(1, "path truncated: '../%s'", tmp);
-               p++;
        }
        relpath = tmp;
 
@@ -747,7 +733,7 @@ writeblob(git_object *obj, const char *fpath, const char *filename, git_off_t fi
        fputs("</p><hr/>", fp);
 
        if (git_blob_is_binary((git_blob *)obj)) {
-               fputs("<p>Binary file</p>\n", fp);
+               fputs("<p>Binary file.</p>\n", fp);
        } else {
                lc = writeblobhtml(fp, (git_blob *)obj);
                if (ferror(fp))
@@ -820,17 +806,12 @@ writefilestree(FILE *fp, git_tree *tree, const char *branch, const char *path)
                if (!(entry = git_tree_entry_byindex(tree, i)) ||
                    !(entryname = git_tree_entry_name(entry)))
                        return -1;
-               r = snprintf(entrypath, sizeof(entrypath), "%s%s%s",
-                        path, path[0] ? "/" : "", entryname);
-               if (r == -1 || (size_t)r >= sizeof(entrypath))
-                       errx(1, "path truncated: '%s%s%s'",
-                               path, path[0] ? "/" : "", entryname);
-
-               r = snprintf(filepath, sizeof(filepath), "file/%s%s%s.html",
-                        path, path[0] ? "/" : "", entryname);
+               joinpath(entrypath, sizeof(entrypath), path, entryname);
+
+               r = snprintf(filepath, sizeof(filepath), "file/%s.html",
+                        entrypath);
                if (r == -1 || (size_t)r >= sizeof(filepath))
-                       errx(1, "path truncated: 'file/%s%s%s.html'",
-                               path, path[0] ? "/" : "", entryname);
+                       errx(1, "path truncated: 'file/%s.html'", entrypath);
 
                if (!git_tree_entry_to_object(&obj, repo, entry)) {
                        switch (git_object_type(obj)) {
@@ -1014,18 +995,6 @@ err:
        return 0;
 }
 
-void
-joinpath(char *buf, size_t bufsiz, const char *path, const char *path2)
-{
-       int r;
-
-       r = snprintf(buf, bufsiz, "%s%s%s",
-               repodir, path[0] && path[strlen(path) - 1] != '/' ? "/" : "", path2);
-       if (r == -1 || (size_t)r >= bufsiz)
-               errx(1, "path truncated: '%s%s%s'",
-                       path, path[0] && path[strlen(path) - 1] != '/' ? "/" : "", path2);
-}
-
 void
 usage(char *argv0)
 {
@@ -1087,9 +1056,9 @@ main(int argc, char *argv[])
                name = "";
 
        /* strip .git suffix */
-       if (!(stripped_name = strdup(name)))
+       if (!(strippedname = strdup(name)))
                err(1, "strdup");
-       if ((p = strrchr(stripped_name, '.')))
+       if ((p = strrchr(strippedname, '.')))
                if (!strcmp(p, ".git"))
                        *p = '\0';
 
@@ -1162,9 +1131,8 @@ main(int argc, char *argv[])
                                n = fread(buf, 1, sizeof(buf), rcachefp);
                                if (ferror(rcachefp))
                                        err(1, "fread");
-                               if (fwrite(buf, 1, n, fp) != n)
-                                       err(1, "fwrite");
-                               if (fwrite(buf, 1, n, wcachefp) != n)
+                               if (fwrite(buf, 1, n, fp) != n ||
+                                   fwrite(buf, 1, n, wcachefp) != n)
                                        err(1, "fwrite");
                        }
                        fclose(rcachefp);