]> git.armaanb.net Git - opendoas.git/blobdiff - doas.c
persist_timestamp: remove goto from persist_open
[opendoas.git] / doas.c
diff --git a/doas.c b/doas.c
index eef89559d10ddd7bca4b0aa4c0bc2dcf1662773b..7c682cfed17e313ca90385e94bad9b9e90b7411a 100644 (file)
--- a/doas.c
+++ b/doas.c
@@ -17,6 +17,7 @@
 
 #include <sys/types.h>
 #include <sys/stat.h>
+#include <sys/ioctl.h>
 
 #include <limits.h>
 #include <string.h>
@@ -28,6 +29,9 @@
 #include <grp.h>
 #include <syslog.h>
 #include <errno.h>
+#if HAVE_SHADOW_H
+#include <shadow.h>
+#endif
 
 #include "includes.h"
 
@@ -43,25 +47,14 @@ version(void)
 static void __dead
 usage(void)
 {
-       fprintf(stderr, "usage: doas [-nsv] [-a style] [-C config] [-u user]"
-           " command [args]\n");
+       fprintf(stderr, "usage: doas [-Lnsv] "
+#ifdef HAVE_BSD_AUTH_H
+           "[-a style] "
+#endif
+           "[-C config] [-u user] command [args]\n");
        exit(1);
 }
 
-size_t
-arraylen(const char **arr)
-{
-       size_t cnt = 0;
-
-       if (arr) {
-               while (*arr) {
-                       cnt++;
-                       arr++;
-               }
-       }
-       return cnt;
-}
-
 static int
 parseuid(const char *s, uid_t *uid)
 {
@@ -147,7 +140,7 @@ match(uid_t uid, gid_t *groups, int ngroups, uid_t target, const char *cmd,
 }
 
 static int
-permit(uid_t uid, gid_t *groups, int ngroups, struct rule **lastr,
+permit(uid_t uid, gid_t *groups, int ngroups, const struct rule **lastr,
     uid_t target, const char *cmd, const char **cmdargs)
 {
        int i;
@@ -194,7 +187,7 @@ static void __dead
 checkconfig(const char *confpath, int argc, char **argv,
     uid_t uid, gid_t *groups, int ngroups, uid_t target)
 {
-       struct rule *rule;
+       const struct rule *rule;
 
        if (setresuid(uid, uid, uid) != 0)
                err(1, "setresuid");
@@ -213,8 +206,118 @@ checkconfig(const char *confpath, int argc, char **argv,
        }
 }
 
+#ifdef HAVE_BSD_AUTH_H
+static void
+authuser(char *myname, char *login_style, int persist)
+{
+       char *challenge = NULL, *response, rbuf[1024], cbuf[128];
+       auth_session_t *as;
+       int fd = -1;
+
+       if (persist)
+               fd = open("/dev/tty", O_RDWR);
+       if (fd != -1) {
+               if (ioctl(fd, TIOCCHKVERAUTH) == 0)
+                       goto good;
+       }
+
+       if (!(as = auth_userchallenge(myname, login_style, "auth-doas",
+           &challenge)))
+               errx(1, "Authorization failed");
+       if (!challenge) {
+               char host[HOST_NAME_MAX + 1];
+               if (gethostname(host, sizeof(host)))
+                       snprintf(host, sizeof(host), "?");
+               snprintf(cbuf, sizeof(cbuf),
+                   "\rdoas (%.32s@%.32s) password: ", myname, host);
+               challenge = cbuf;
+       }
+       response = readpassphrase(challenge, rbuf, sizeof(rbuf),
+           RPP_REQUIRE_TTY);
+       if (response == NULL && errno == ENOTTY) {
+               syslog(LOG_AUTHPRIV | LOG_NOTICE,
+                   "tty required for %s", myname);
+               errx(1, "a tty is required");
+       }
+       if (!auth_userresponse(as, response, 0)) {
+               syslog(LOG_AUTHPRIV | LOG_NOTICE,
+                   "failed auth for %s", myname);
+               errx(1, "Authorization failed");
+       }
+       explicit_bzero(rbuf, sizeof(rbuf));
+good:
+       if (fd != -1) {
+               int secs = 5 * 60;
+               ioctl(fd, TIOCSETVERAUTH, &secs);
+               close(fd);
+       }
+}
+#elif HAVE_SHADOW_H
+static void
+authuser(const char *myname, const char *login_style, int persist)
+{
+       const char *hash;
+       char *encrypted;
+       struct passwd *pw;
+
+       (void)login_style;
+
+#ifdef PERSIST_TIMESTAMP
+       int fd = -1;
+       int valid;
+       if (persist)
+               fd = persist_open(&valid, 5 * 60);
+       if (fd != -1 && valid)
+               goto good;
+#else
+       (void)persist;
+#endif
+
+       if (!(pw = getpwnam(myname)))
+               err(1, "getpwnam");
+
+       hash = pw->pw_passwd;
+       if (hash[0] == 'x' && hash[1] == '\0') {
+               struct spwd *sp;
+               if (!(sp = getspnam(myname)))
+                       errx(1, "Authorization failed");
+               hash = sp->sp_pwdp;
+       } else if (hash[0] != '*') {
+               errx(1, "Authorization failed");
+       }
+
+       char *challenge, *response, rbuf[1024], cbuf[128], host[HOST_NAME_MAX + 1];
+       if (gethostname(host, sizeof(host)))
+               snprintf(host, sizeof(host), "?");
+       snprintf(cbuf, sizeof(cbuf),
+                       "\rdoas (%.32s@%.32s) password: ", myname, host);
+       challenge = cbuf;
+
+       response = readpassphrase(challenge, rbuf, sizeof(rbuf), RPP_REQUIRE_TTY);
+       if (response == NULL && errno == ENOTTY) {
+               syslog(LOG_AUTHPRIV | LOG_NOTICE,
+                       "tty required for %s", myname);
+               errx(1, "a tty is required");
+       }
+       if (!(encrypted = crypt(response, hash)))
+               errx(1, "crypt");
+       if (strcmp(encrypted, hash) != 0) {
+               syslog(LOG_AUTHPRIV | LOG_NOTICE, "failed auth for %s", myname);
+               errx(1, "Authorization failed");
+       }
+       explicit_bzero(rbuf, sizeof(rbuf));
+#ifdef PERSIST_TIMESTAMP
+good:
+       if (fd != -1) {
+               persist_set(fd, 5 * 60);
+               close(fd);
+       }
+#endif
+}
+#endif /* HAVE_BSD_AUTH_H */
+
 int
-main(int argc, char **argv, char **envp)
+main(int argc, char **argv)
 {
        const char *safepath = "/bin:/sbin:/usr/bin:/usr/sbin:"
            "/usr/local/bin:/usr/local/sbin";
@@ -222,11 +325,10 @@ main(int argc, char **argv, char **envp)
        char *shargv[] = { NULL, NULL };
        char *sh;
        const char *cmd;
-       struct env *env;
        char cmdline[LINE_MAX];
        char myname[_PW_NAME_LEN + 1];
        struct passwd *pw;
-       struct rule *rule;
+       const struct rule *rule;
        uid_t uid;
        uid_t target = 0;
        gid_t groups[NGROUPS_MAX + 1];
@@ -237,23 +339,19 @@ main(int argc, char **argv, char **envp)
        int vflag = 0;
        char cwdpath[PATH_MAX];
        const char *cwd;
-#ifdef HAVE_BSD_AUTH_H
+       char **envp;
        char *login_style = NULL;
-#endif
 
        setprogname("doas");
 
-       if (pledge("stdio rpath getpw tty proc exec id", NULL) == -1)
-               err(1, "pledge");
-
-       /* closefrom(STDERR_FILENO + 1); */
+       closefrom(STDERR_FILENO + 1);
 
        uid = getuid();
 
 #ifdef HAVE_BSD_AUTH_H
-# define OPTSTRING "a:C:nsu:v"
+# define OPTSTRING "a:C:Lnsu:v"
 #else
-# define OPTSTRING "C:nsu:v"
+# define OPTSTRING "+C:Lnsu:v"
 #endif
 
        while ((ch = getopt(argc, argv, OPTSTRING)) != -1) {
@@ -266,6 +364,15 @@ main(int argc, char **argv, char **envp)
                case 'C':
                        confpath = optarg;
                        break;
+               case 'L':
+#ifdef TIOCCLRVERAUTH
+                       i = open("/dev/tty", O_RDWR);
+                       if (i != -1)
+                               ioctl(i, TIOCCLRVERAUTH);
+                       exit(i == -1);
+#elif PERSIST_TIMESTAMP
+                       exit(persist_clear() != 0);
+#endif
                case 'u':
                        if (parseuid(optarg, &target) != 0)
                                errx(1, "unknown user");
@@ -308,9 +415,11 @@ main(int argc, char **argv, char **envp)
 
        if (sflag) {
                sh = getenv("SHELL");
-               if (sh == NULL || *sh == '\0')
-                       shargv[0] = pw->pw_shell;
-               else
+               if (sh == NULL || *sh == '\0') {
+                       shargv[0] = strdup(pw->pw_shell);
+                       if (shargv[0] == NULL)
+                               err(1, NULL);
+               } else
                        shargv[0] = sh;
                argv = shargv;
                argc = 1;
@@ -322,10 +431,13 @@ main(int argc, char **argv, char **envp)
                exit(1);        /* fail safe */
        }
 
+       if (geteuid())
+               errx(1, "not installed setuid");
+
        parseconfig("/etc/doas.conf", 1);
 
        /* cmdline is used only for logging, no need to abort on truncate */
-       (void) strlcpy(cmdline, argv[0], sizeof(cmdline));
+       (void)strlcpy(cmdline, argv[0], sizeof(cmdline));
        for (i = 1; i < argc; i++) {
                if (strlcat(cmdline, " ", sizeof(cmdline)) >= sizeof(cmdline))
                        break;
@@ -335,62 +447,39 @@ main(int argc, char **argv, char **envp)
 
        cmd = argv[0];
        if (!permit(uid, groups, ngroups, &rule, target, cmd,
-           (const char**)argv + 1)) {
+           (const char **)argv + 1)) {
                syslog(LOG_AUTHPRIV | LOG_NOTICE,
                    "failed command for %s: %s", myname, cmdline);
                errc(1, EPERM, NULL);
        }
 
-       pw = getpwuid(target);
-       if (!pw)
-               errx(1, "no passwd entry for target");
-
-#ifdef HAVE_BSD_AUTH_H
+#if defined(HAVE_BSD_AUTH_H) || defined(HAVE_SHADOW_H)
        if (!(rule->options & NOPASS)) {
                if (nflag)
                        errx(1, "Authorization required");
 
-               char *challenge = NULL, *response, rbuf[1024], cbuf[128];
-               auth_session_t *as;
-
-               if (!(as = auth_userchallenge(myname, login_style, "auth-doas",
-                   &challenge)))
-                       errx(1, "Authorization failed");
-               if (!challenge) {
-                       char host[HOST_NAME_MAX + 1];
-                       if (gethostname(host, sizeof(host)))
-                               snprintf(host, sizeof(host), "?");
-                       snprintf(cbuf, sizeof(cbuf),
-                           "\rdoas (%.32s@%.32s) password: ", myname, host);
-                       challenge = cbuf;
-               }
-               response = readpassphrase(challenge, rbuf, sizeof(rbuf),
-                   RPP_REQUIRE_TTY);
-               if (response == NULL && errno == ENOTTY) {
-                       syslog(LOG_AUTHPRIV | LOG_NOTICE,
-                           "tty required for %s", myname);
-                       errx(1, "a tty is required");
-               }
-               if (!auth_userresponse(as, response, 0)) {
-                       syslog(LOG_AUTHPRIV | LOG_NOTICE,
-                           "failed auth for %s", myname);
-                       errc(1, EPERM, NULL);
-               }
-               explicit_bzero(rbuf, sizeof(rbuf));
+               authuser(myname, login_style, rule->options & PERSIST);
        }
 #elif HAVE_PAM_APPL_H
-       if (!doas_pam(pw->pw_name, myname, !nflag, rule->options & NOPASS)) {
+       pw = getpwuid(target);
+       if (!pw)
+               errx(1, "no passwd entry for target");
+
+       if (!pamauth(pw->pw_name, myname, !nflag, rule->options & NOPASS)) {
                syslog(LOG_AUTHPRIV | LOG_NOTICE, "failed auth for %s", myname);
-               errc(1, EPERM, NULL);
+               errx(1, "Authorization failed");
        }
 #else
-       if (!(rule->options & NOPASS)) {
-                       errx(1, "Authorization required");
+#error "No authentication method"
 #endif /* HAVE_BSD_AUTH_H */
 
        if (pledge("stdio rpath getpw exec id", NULL) == -1)
                err(1, "pledge");
 
+       pw = getpwuid(target);
+       if (!pw)
+               errx(1, "no passwd entry for target");
+
 #ifdef HAVE_BSD_AUTH_H
        if (setusercontext(NULL, pw, target, LOGIN_SETGROUP |
            LOGIN_SETPRIORITY | LOGIN_SETRESOURCES | LOGIN_SETUMASK |
@@ -398,11 +487,11 @@ main(int argc, char **argv, char **envp)
                errx(1, "failed to set user context for target");
 #else
        if (setresgid(pw->pw_gid, pw->pw_gid, pw->pw_gid) != 0)
-               errx(1, "setgid");
+               errx(1, "setresgid");
        if (initgroups(pw->pw_name, pw->pw_gid) != 0)
                errx(1, "initgroups");
        if (setresuid(target, target, target) != 0)
-               errx(1, "setuid");
+               errx(1, "setresuid");
 #endif
 
        if (pledge("stdio rpath exec", NULL) == -1)
@@ -419,9 +508,7 @@ main(int argc, char **argv, char **envp)
        syslog(LOG_AUTHPRIV | LOG_INFO, "%s ran command %s as %s from %s",
            myname, cmdline, pw->pw_name, cwd);
 
-       env = createenv(envp);
-       env = filterenv(env, rule);
-       envp = flattenenv(env);
+       envp = prepenv(rule);
 
        if (rule->cmd) {
                if (setenv("PATH", safepath, 1) == -1)