Actually open pam sessions

[opendoas.git] / libopenbsd / auth_userokay.c

diff --git a/libopenbsd/auth_userokay.c b/libopenbsd/auth_userokay.c
index 465cb1c8f194f0be4ec4346ae0e722041304e185..6a9841b3b198a343103c3e31227822a80585bb3f 100644 (file)
--- a/libopenbsd/auth_userokay.c
+++ b/libopenbsd/auth_userokay.c
@@ -26,7 +26,7 @@
 
 #include "includes.h"
 
-#define PAM_SERVICE "doas"
+#define PAM_SERVICE_NAME "doas"
 
 static char *
 pam_prompt(const char *msg, int echo_on, int *pam)
@@ -93,17 +93,20 @@ auth_userokay(char *name, char *style, char *type, char *password)
        if (style || type || password)
                errx(1, "auth_userokay(name, NULL, NULL, NULL)!\n");
 
-       ret = pam_start(PAM_SERVICE, name, &conv, &pamh);
+       ret = pam_start(PAM_SERVICE_NAME, name, &conv, &pamh);
        if (ret != PAM_SUCCESS)
                errx(1, "pam_start(\"%s\", \"%s\", ?, ?): failed\n",
-                               PAM_SERVICE, name);
+                               PAM_SERVICE_NAME, name);
 
        auth = pam_authenticate(pamh, 0);
 
+       ret = pam_open_session(pamh, 0);
+       if (ret != PAM_SUCCESS)
+               errx(1, "pam_open_session(): %s\n", pam_strerror(pamh, ret));
+
        ret = pam_close_session(pamh, 0);
        if (ret != PAM_SUCCESS)
                errx(1, "pam_close_session(): %s\n", pam_strerror(pamh, ret));
 
        return auth == PAM_SUCCESS;
 }
-