add argument parsing, fix program logic

[phrases.git] / phrases.py

diff --git a/phrases.py b/phrases.py
index c00f415f2a4139499fe7cccae17367df8117c5e2..63199d141d996cccc70d160ad3f71438f2909a32 100755 (executable)
--- a/phrases.py
+++ b/phrases.py
@@ -3,44 +3,84 @@
 # Armaan Bhojwani 2020
 
 import argparse
+import csv
 import random
 import sys
-import csv
 
-# Main program
 def main(args=sys.argv[1:]):
-    parser = argparse.ArgumentParser(description="Latin famous phrases in the terminal.")
-    parser.add_argument("-e", "--english", action='store_true', help="Print the English translation.")
-    parser.add_argument("-i", "--id", action='store_true', help="Print the id of the phrase.")
-    parser.add_argument("-l", "--latin", action='store_true', help="Print the Latin phrase (default)")
-    parser.add_argument("-m", "--min", type=int, default=0, help="Set the minimum length of the Latin phrase")
-    parser.add_argument("-M", "--max", type=int, default=10000000, help="Set the maximum length of Latin phrase")
-    parser.add_argument("-n", "--notes", action='store_true', help="Print any notes on phrase")
+    # Argument parsing
+    parser = argparse.ArgumentParser(
+        description="Latin famous phrases in the terminal.")
+    parser.add_argument("-i", "--id",
+                        action='store_true',
+                        help="print the id of the phrase.")
+    parser.add_argument("-l", "--latin",
+                        action='store_true',
+                        help="print the Latin phrase (default)")
+    parser.add_argument("-e", "--english",
+                        action='store_true',
+                        help="print the English translation.")
+    parser.add_argument("-n", "--notes",
+                        action='store_true',
+                        help="print any notes on phrase")
+    parser.add_argument("-m", "--min",
+                        default=0,
+                        type=int,
+                        help="set the minimum length of the Latin phrase")
+    parser.add_argument("-M", "--max",
+                        default=10000000,
+                        type=int,
+                        help="set the maximum length of Latin phrase")
+    parser.add_argument("-p", "--num",
+                        action='store_true',
+                        help="print number of possibilities within constraints")
+    parser.add_argument("-f", "--file",
+                        default="/usr/share/phrases/phrases.csv",
+                        help="set the location of the phrase file")
     args = parser.parse_args()
 
-    id = []
+    right_length = []
 
-    with open('/usr/share/phrases/phrases.csv') as f:
+    # convert csv file into list
+    with open(args.file) as f:
         reader = csv.reader(f)
-        for row in reader:
-            if args.max >= int(row[len(row) - 1]) >= args.min:
-                id.append(row[0])
-        chosen = id[random.randint(0, len(id))]
+        next(reader, None) # skip header
+        all_lines = list(reader) 
+    f.close()
 
-    with open('/usr/share/phrases/phrases.csv') as f:
-        reader = csv.reader(f)
-        for row in reader:
-            if row[0] == chosen:
+    # iterate through all the phrases
+    for row in all_lines:
+        try: # generate a shortlist of phrases of the right length
+            if args.max >= int(row[4]) >= args.min:
+                right_length.append(row[0])
+        except: # skip malformed rows without exiting
+            pass
+
+    try: # choose a random id from the shortlist
+        chosen = int(right_length[random.randint(0, len(right_length) - 1)])
+    except:
+        sys.exit("No phrase within the given parameters!")
+
+    # Output as specified in flags
+    for row in all_lines:
+        if int(row[0]) == chosen:
+            if not (args.id
+                    or args.latin
+                    or args.english
+                    or args.notes
+                    or args.num):
+                print(row[1])
+            else:
                 if args.id:
-                    print(row[0])
+                    print(row[1])
                 if args.latin:
                     print(row[1])
                 if args.english:
                     print(row[2])
                 if args.notes:
                     print(row[3])
-                if not len(sys.argv) > 1:
-                    print(row[1])
+                if args.num:
+                    print(len(right_length))
 
 if __name__ == "__main__":
     main()