dup() -> dup2()

gcc would warn about an unused result. We know it is 0 and dup()
can't fail in these circumstances, as we closed fd0 previously.
Using dup2() to do the same saves one line and shuts gcc up, bringing
us a clean build back.

diff --git a/st.c b/st.c
index bd8b81591e0d52bed9fcd7604ceef3017525614f..bcf74b3c3f36271ca92ac7d56f27a61773446080 100644 (file)
--- a/st.c
+++ b/st.c
@@ -1430,8 +1430,7 @@ ttynew(void)
        if (opt_line) {
                if ((cmdfd = open(opt_line, O_RDWR)) < 0)
                        die("open line failed: %s\n", strerror(errno));
-               close(0);
-               dup(cmdfd);
+               dup2(cmdfd, 0);
                stty();
                return;
        }