]> git.armaanb.net Git - stagit.git/commitdiff
dont truncate summary length anymore
authorHiltjo Posthuma <hiltjo@codemadness.org>
Sun, 7 May 2017 10:02:48 +0000 (12:02 +0200)
committerHiltjo Posthuma <hiltjo@codemadness.org>
Sun, 7 May 2017 10:06:45 +0000 (12:06 +0200)
make sure not partial (invalid) utf-8 sequences are written. The old logic
truncated by bytelen was wrong. It is too complex to implement it in a
correct way with git: it is not assured a commit message is UTF-8 encoded.

remove showlinecount and summarylen variables.

stagit.c

index 5eb5f1c6d198ffb4109ddae54a43080cdad76415..d310a583f3e4d0a9b76c249d05f719a9e05b0036 100644 (file)
--- a/stagit.c
+++ b/stagit.c
@@ -46,11 +46,6 @@ struct commitinfo {
        size_t ndeltas;
 };
 
-/* summary length (bytes) in the log */
-static const unsigned summarylen = 70;
-/* display line count or file size in file tree index */
-static const int showlinecount = 1;
-
 static git_repository *repo;
 
 static const char *relpath = "";
@@ -537,20 +532,13 @@ printshowfile(FILE *fp, struct commitinfo *ci)
 void
 writelogline(FILE *fp, struct commitinfo *ci)
 {
-       size_t len;
-
        fputs("<tr><td>", fp);
        if (ci->author)
                printtimeshort(fp, &(ci->author->when));
        fputs("</td><td>", fp);
        if (ci->summary) {
                fprintf(fp, "<a href=\"%scommit/%s.html\">", relpath, ci->oid);
-               if ((len = strlen(ci->summary)) > summarylen) {
-                       xmlencode(fp, ci->summary, summarylen - 1);
-                       fputs("…", fp);
-               } else {
-                       xmlencode(fp, ci->summary, len);
-               }
+               xmlencode(fp, ci->summary, strlen(ci->summary));
                fputs("</a>", fp);
        }
        fputs("</td><td>", fp);
@@ -836,7 +824,7 @@ writefilestree(FILE *fp, git_tree *tree, const char *path)
                        fprintf(fp, "</td><td><a href=\"%s%s\">", relpath, filepath);
                        xmlencode(fp, entrypath, strlen(entrypath));
                        fputs("</a></td><td class=\"num\" align=\"right\">", fp);
-                       if (showlinecount && lc > 0)
+                       if (lc > 0)
                                fprintf(fp, "%dL", lc);
                        else
                                fprintf(fp, "%juB", (uintmax_t)filesize);