fixed output from commands without a newline end.

[dwmblocks.git] / dwmblocks.c

diff --git a/dwmblocks.c b/dwmblocks.c
index 3e27b0b833c21928304a69b917f13a60dc176dbf..b6f696ff745162a907f296c5f8a04d1d528f6a0f 100644 (file)
--- a/dwmblocks.c
+++ b/dwmblocks.c
@@ -13,6 +13,7 @@
 #endif
 #define LENGTH(X)               (sizeof(X) / sizeof (X[0]))
 #define CMDLENGTH              50
+#define MIN( a, b ) ( ( a < b) ? a : b )
 #define STATUSLENGTH (LENGTH(blocks) * CMDLENGTH + 1)
 
 typedef struct {
@@ -26,13 +27,13 @@ void dummysighandler(int num);
 #endif
 void sighandler(int num);
 void getcmds(int time);
-void getsigcmds(int signal);
+void getsigcmds(unsigned int signal);
 void setupsignals();
 void sighandler(int signum);
 int getstatus(char *str, char *last);
 void setroot();
 void statusloop();
-void termhandler(int signum);
+void termhandler();
 
 
 #include "blocks.h"
@@ -49,24 +50,26 @@ static void (*writestatus) () = setroot;
 void getcmd(const Block *block, char *output)
 {
        strcpy(output, block->icon);
-       char *cmd = block->command;
-       FILE *cmdf = popen(cmd,"r");
+       FILE *cmdf = popen(block->command, "r");
        if (!cmdf)
                return;
-       char c;
        int i = strlen(block->icon);
-       fgets(output+i, CMDLENGTH-i, cmdf);
+       fgets(output+i, CMDLENGTH-i-delimLen, cmdf);
        i = strlen(output);
-       if (delim != '\0' && --i)
-               output[i++] = delim;
-       output[i++] = '\0';
+       if (delim[0] != '\0') {
+               //only chop off newline if one is present at the end
+               i = output[i-1] == '\n' ? i-1 : i;
+               strncpy(output+i, delim, delimLen); 
+       }
+       else
+               output[i++] = '\0';
        pclose(cmdf);
 }
 
 void getcmds(int time)
 {
        const Block* current;
-       for(int i = 0; i < LENGTH(blocks); i++)
+       for (unsigned int i = 0; i < LENGTH(blocks); i++)
        {
                current = blocks + i;
                if ((current->interval != 0 && time % current->interval == 0) || time == -1)
@@ -74,10 +77,10 @@ void getcmds(int time)
        }
 }
 
-void getsigcmds(int signal)
+void getsigcmds(unsigned int signal)
 {
        const Block *current;
-       for (int i = 0; i < LENGTH(blocks); i++)
+       for (unsigned int i = 0; i < LENGTH(blocks); i++)
        {
                current = blocks + i;
                if (current->signal == signal)
@@ -89,11 +92,11 @@ void setupsignals()
 {
 #ifndef __OpenBSD__
            /* initialize all real time signals with dummy handler */
-    for(int i = SIGRTMIN; i <= SIGRTMAX; i++)
+    for (int i = SIGRTMIN; i <= SIGRTMAX; i++)
         signal(i, dummysighandler);
 #endif
 
-       for(int i = 0; i < LENGTH(blocks); i++)
+       for (unsigned int i = 0; i < LENGTH(blocks); i++)
        {
                if (blocks[i].signal > 0)
                        signal(SIGMINUS+blocks[i].signal, sighandler);
@@ -105,9 +108,9 @@ int getstatus(char *str, char *last)
 {
        strcpy(last, str);
        str[0] = '\0';
-       for(int i = 0; i < LENGTH(blocks); i++)
+       for (unsigned int i = 0; i < LENGTH(blocks); i++)
                strcat(str, statusbar[i]);
-       str[strlen(str)-1] = '\0';
+       str[strlen(str)-strlen(delim)] = '\0';
        return strcmp(str, last);//0 if they are the same
 }
 
@@ -139,12 +142,11 @@ void statusloop()
        setupsignals();
        int i = 0;
        getcmds(-1);
-       while(statusContinue)
+       while (statusContinue)
        {
-               getcmds(i);
+               getcmds(i++);
                writestatus();
                sleep(1.0);
-               i++;
        }
 }
 
@@ -162,21 +164,21 @@ void sighandler(int signum)
        writestatus();
 }
 
-void termhandler(int signum)
+void termhandler()
 {
        statusContinue = 0;
-       exit(0);
 }
 
 int main(int argc, char** argv)
 {
-       for(int i = 0; i < argc; i++)
+       for (int i = 0; i < argc; i++) //Handle command line arguments
        {
                if (!strcmp("-d",argv[i]))
-                       delim = argv[++i][0];
-               else if(!strcmp("-p",argv[i]))
+                       strncpy(delim, argv[++i], delimLen);
+               else if (!strcmp("-p",argv[i]))
                        writestatus = pstdout;
        }
+       delim[MIN(delimLen, strlen(delim))] = '\0';
        signal(SIGTERM, termhandler);
        signal(SIGINT, termhandler);
        statusloop();