]> git.armaanb.net Git - sic.git/blobdiff - sic.c
testing some simplifications
[sic.git] / sic.c
diff --git a/sic.c b/sic.c
index e5dc50ae4b8f52a6de360b493d051eeae2ea3fc0..efb0507a3d4062e1f4314c85f7d42b6ef5ca4f76 100644 (file)
--- a/sic.c
+++ b/sic.c
@@ -49,15 +49,15 @@ pout(char *channel, char *msg) {
        static char timestr[18];
        time_t t = time(0);
 
-       strftime(timestr, sizeof(timestr), "%F %R", localtime(&t));
+       strftime(timestr, sizeof timestr, "%F %R", localtime(&t));
        fprintf(stdout, "%-8.8s: %s %s\n", channel, timestr, msg);
 }
 
 static void
 privmsg(char *channel, char *msg) {
-       snprintf(bufout, sizeof(bufout), "<%s> %s", nick, msg);
+       snprintf(bufout, sizeof bufout, "<%s> %s", nick, msg);
        pout(channel, bufout);
-       snprintf(bufout, sizeof(bufout), "PRIVMSG %s :%s\r\n", channel, msg);
+       snprintf(bufout, sizeof bufout, "PRIVMSG %s :%s\r\n", channel, msg);
        write(srv, bufout, strlen(bufout));
 }
 
@@ -67,14 +67,14 @@ parsein(char *msg) {
 
        if(msg[0] == 0)
                return;
-       if(msg[0] != '/') {
+       if(msg[0] != ':') {
                privmsg(channel, msg);
                return;
        }
        if(!strncmp(msg + 1, "j ", 2) && (msg[3] == '#'))
-               snprintf(bufout, sizeof(bufout), "JOIN %s\r\n", &msg[3]);
+               snprintf(bufout, sizeof bufout, "JOIN %s\r\n", &msg[3]);
        else if(!strncmp(msg + 1, "l ", 2))
-               snprintf(bufout, sizeof(bufout), "PART %s :sic\r\n", &msg[3]);
+               snprintf(bufout, sizeof bufout, "PART %s :sic - 300 LOC are too much!\r\n", &msg[3]);
        else if(!strncmp(msg + 1, "m ", 2)) {
                if((p = strchr(&msg[3], ' ')))
                        *(p++) = 0;
@@ -82,16 +82,16 @@ parsein(char *msg) {
                return;
        }
        else if(!strncmp(msg + 1, "s ", 2)) {
-               strncpy(channel, &msg[3], sizeof(channel));
+               strncpy(channel, &msg[3], sizeof channel);
                return;
        }
        else if(!strncmp(msg + 1, "t ", 2)) {
                if((p = strchr(&msg[3], ' ')))
                        *(p++) = 0;
-               snprintf(bufout, sizeof(bufout), "TOPIC %s :%s\r\n", &msg[3], p);
+               snprintf(bufout, sizeof bufout, "TOPIC %s :%s\r\n", &msg[3], p);
        }
        else
-               snprintf(bufout, sizeof(bufout), "%s\r\n", &msg[1]);
+               snprintf(bufout, sizeof bufout, "%s\r\n", &msg[1]);
        write(srv, bufout, strlen(bufout));
 }
 
@@ -127,10 +127,8 @@ parsesrv(char *msg) {
 
        if(!msg || !(*msg))
                return;
-
        for(i = 0; i < Tlast; i++)
                argv[i] = NULL;
-
        /* <bufout>  ::= [':' <prefix> <SPACE> ] <command> <params> <crlf>
         * <prefix>   ::= <servername> | <nick> [ '!' <user> ] [ '@' <server> ]
         * <command>  ::= <letter> { <letter> } | <number> <number> <number>
@@ -142,7 +140,8 @@ parsesrv(char *msg) {
         * <crlf>     ::= CR LF
         */
        if(msg[0] == ':') { /* check prefix */
-               p = strchr(msg, ' ');
+               if (!(p = strchr(msg, ' ')))
+                       return;
                *p = 0;
                for(++p; *p == ' '; p++);
                cmd = p;
@@ -161,64 +160,23 @@ parsesrv(char *msg) {
                *p = 0;
                argv[Ttext] = ++p;
        }
-       tokenize(&argv[Tcmd], Tlast - Tcmd, cmd, ' ');
-       if(!strncmp("PONG", argv[Tcmd], 5))
-               return;
-       else if(!strncmp("PING", argv[Tcmd], 5)) {
-               snprintf(bufout, sizeof(bufout), "PONG %s\r\n", argv[Ttext]);
-               write(srv, bufout, strlen(bufout));
-               return;
-       }
-       else if(!argv[Tnick] || !argv[Tuser]) { /* server command */
-               snprintf(bufout, sizeof(bufout), "%s", argv[Ttext] ? argv[Ttext] : "");
-               pout(server, bufout);
-               return;
-       }
-       else if(!strncmp("ERROR", argv[Tcmd], 6))
-               snprintf(bufout, sizeof(bufout), "-!- error %s",
-                               argv[Ttext] ? argv[Ttext] : "unknown");
-       else if(!strncmp("JOIN", argv[Tcmd], 5)) {
-               if(argv[Ttext]!=NULL){
-                       p = strchr(argv[Ttext], ' ');
-               if(p)
-                       *p = 0;
+
+       if(!strncmp("PRIVMSG", cmd, 7) || !strncmp("PING", cmd, 4)) {
+               if(tokenize(&argv[Tcmd], Tlast - Tcmd, cmd, ' ') != Tlast - Tcmd)
+                       return;
+               if(!strncmp("PRIVMSG", argv[Tcmd], 8)) {
+                       snprintf(bufout, sizeof bufout, "<%s> %s",
+                                       argv[Tnick], argv[Ttext] ? argv[Ttext] : "");
+                       pout(argv[Tchan], bufout);
                }
-               argv[Tchan] = argv[Ttext];
-               snprintf(bufout, sizeof(bufout), "-!- %s(%s) has joined %s",
-                               argv[Tnick], argv[Tuser], argv[Ttext]);
-       }
-       else if(!strncmp("PART", argv[Tcmd], 5)) {
-               snprintf(bufout, sizeof(bufout), "-!- %s(%s) has left %s",
-                               argv[Tnick], argv[Tuser], argv[Tchan]);
+               else if(!strncmp("PING", argv[Tcmd], 5)) {
+                       snprintf(bufout, sizeof bufout, "PONG %s\r\n", argv[Ttext]);
+                       write(srv, bufout, strlen(bufout));
+               }
+               return;
        }
-       else if(!strncmp("MODE", argv[Tcmd], 5))
-               snprintf(bufout, sizeof(bufout), "-!- %s changed mode/%s -> %s %s",
-                               argv[Tnick], argv[Tcmd + 1],
-                               argv[Tcmd + 2], argv[Tcmd + 3]);
-       else if(!strncmp("QUIT", argv[Tcmd], 5))
-               snprintf(bufout, sizeof(bufout), "-!- %s(%s) has quit \"%s\"",
-                               argv[Tnick], argv[Tuser],
-                               argv[Ttext] ? argv[Ttext] : "");
-       else if(!strncmp("NICK", argv[Tcmd], 5))
-               snprintf(bufout, sizeof(bufout), "-!- %s changed nick to %s",
-                               argv[Tnick], argv[Ttext]);
-       else if(!strncmp("TOPIC", argv[Tcmd], 6))
-               snprintf(bufout, sizeof(bufout), "-!- %s changed topic to \"%s\"",
-                               argv[Tnick], argv[Ttext] ? argv[Ttext] : "");
-       else if(!strncmp("KICK", argv[Tcmd], 5))
-               snprintf(bufout, sizeof(bufout), "-!- %s kicked %s (\"%s\")",
-                               argv[Tnick], argv[Targ],
-                               argv[Ttext] ? argv[Ttext] : "");
-       else if(!strncmp("NOTICE", argv[Tcmd], 7))
-               snprintf(bufout, sizeof(bufout), "-!- \"%s\")",
-                               argv[Ttext] ? argv[Ttext] : "");
-       else if(!strncmp("PRIVMSG", argv[Tcmd], 8))
-               snprintf(bufout, sizeof(bufout), "<%s> %s",
-                               argv[Tnick], argv[Ttext] ? argv[Ttext] : "");
-       if(!argv[Tchan] || !strncmp(argv[Tchan], nick, strlen(nick)))
-               pout(argv[Tnick], bufout);
-       else
-               pout(argv[Tchan], bufout);
+       snprintf(bufout, sizeof bufout, "-!- %s", cmd);
+       pout(server, bufout);
 }
 
 int
@@ -276,14 +234,14 @@ main(int argc, char *argv[]) {
        }
        /* login */
        if(password)
-               snprintf(bufout, sizeof(bufout),
+               snprintf(bufout, sizeof bufout,
                                "PASS %s\r\nNICK %s\r\nUSER %s localhost %s :%s\r\n",
                                password, nick, nick, server, fullname);
        else
-               snprintf(bufout, sizeof(bufout), "NICK %s\r\nUSER %s localhost %s :%s\r\n",
+               snprintf(bufout, sizeof bufout, "NICK %s\r\nUSER %s localhost %s :%s\r\n",
                                 nick, nick, server, fullname);
        write(srv, bufout, strlen(bufout));
-       snprintf(ping, sizeof(ping), "PING %s\r\n", server);
+       snprintf(ping, sizeof ping, "PING %s\r\n", server);
        channel[0] = 0;
        setbuf(stdout, NULL); /* unbuffered stdout */
 
@@ -301,14 +259,14 @@ main(int argc, char *argv[]) {
                        exit(EXIT_FAILURE);
                } else if(i == 0) {
                        if(time(NULL) - trespond >= PINGTIMEOUT) {
-                               pout(server, "-!- sic shutting down: parseing timeout");
+                               pout(server, "-!- sic shutting down: parse timeout");
                                exit(EXIT_FAILURE);
                        }
                        write(srv, ping, strlen(ping));
                        continue;
                }
                if(FD_ISSET(srv, &rd)) {
-                       if(getline(srv, sizeof(bufin), bufin) == -1) {
+                       if(getline(srv, sizeof bufin, bufin) == -1) {
                                perror("sic: remote server closed connection");
                                exit(EXIT_FAILURE);
                        }
@@ -316,7 +274,7 @@ main(int argc, char *argv[]) {
                        trespond = time(NULL);
                }
                if(FD_ISSET(0, &rd)) {
-                       if(getline(0, sizeof(bufin), bufin) == -1) {
+                       if(getline(0, sizeof bufin, bufin) == -1) {
                                perror("sic: broken pipe");
                                exit(EXIT_FAILURE);
                        }